Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(native-filters): make fetch predicate optional #14264

Closed
wants to merge 1 commit into from
Closed

feat(native-filters): make fetch predicate optional #14264

wants to merge 1 commit into from

Conversation

villebro
Copy link
Member

SUMMARY

Make fetch values predicate optional in Select and Range filters.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Apr 26, 2021
@villebro villebro force-pushed the villebro/fetch-native-predicate branch from ee07c63 to d857862 Compare May 12, 2021 07:17
@villebro villebro changed the title [WIP] feat(native-filters): make fetch predicate optional feat(native-filters): make fetch predicate optional May 12, 2021
@villebro villebro closed this Jun 4, 2021
@villebro villebro mentioned this pull request Jun 4, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dashboard:native-filters Related to the native filters of the Dashboard preset-io size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@villebro @junlincc